Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid merge commits if possible #120

Open
purpleidea opened this issue Oct 21, 2016 · 4 comments
Open

Avoid merge commits if possible #120

purpleidea opened this issue Oct 21, 2016 · 4 comments

Comments

@purpleidea
Copy link
Collaborator

Yesterday I submitted a very simple patch which applied directly to git master:

dd29b1f

Thanks for merging it, however it was done with a merge commit:

644521d

I'd like to propose that we avoid merge commits as much as possible, and in particular when there is only one pending patch, we should get it rebase to git master so that it can apply with a fast forward.

IOW, don't click the green merge button in it's current state. Much better to change the button to default to rebase if we plan on using it at all, or apply these kinds of patches with the cli.

Just my $0.02

Cheers!

@purpleidea
Copy link
Collaborator Author

Here's a nice example for this: #121

@vincentbernat
Copy link
Collaborator

I don't have a strong opinion on that. Rebase or regular merge are fine by me. Squash is not.

@purpleidea
Copy link
Collaborator Author

Yes, I agree we shouldn't squash. Fast forwarding is my preferred approach when available. Keeps the history logical and easy to understand.

@rgbkrk
Copy link
Owner

rgbkrk commented Oct 21, 2016

Rebase is good, we can set that as the default on the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants