Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonitoringStack errors on quota for thanos-sidecar pod #528

Open
grigassukys opened this issue Jul 8, 2024 · 1 comment
Open

MonitoringStack errors on quota for thanos-sidecar pod #528

grigassukys opened this issue Jul 8, 2024 · 1 comment

Comments

@grigassukys
Copy link

Hello,

We have an issue with Cluster Observability Operator, in particular when creating MonitoringStack.
For example when using this yaml:

apiVersion: monitoring.rhobs/v1alpha1
kind: MonitoringStack
metadata:
  labels:
    mso: test-prometheus
  name: test-monitoring-stack
  namespace: test-monitoring
spec:
  alertmanagerConfig:
    disabled: true
  namespaceSelector:
    matchExpressions:
      - values:
          - test-monitoring
        key: kubernetes.io/metadata.name
        operator: In
  logLevel: debug
  resourceSelector:
    matchLabels:
      app: test-metrics
  retention: 1d

The Monitoring Stack is created and in Resources tab we can see:

"test-monitoring-stack-prometheus"
"test-monitoring-stack-prometheus-additional-scrape-configs"
"test-monitoring-stack-thanos-sidecar"
 

The problem is, that prometheus pods cannot start, because we get the following error:
"create Pod prometheus-test-monitoring-stack-0 in StatefulSet prometheus-test-monitoring-stack failed error: pods "prometheus-test-monitoring-stack-0" is forbidden: failed quota: test-monitoring-quota-compute-resources: must specify limits.cpu for: thanos-sidecar; limits.memory for: thanos-sidecar; requests.cpu for: thanos-sidecar; requests.memory for: thanos-sidecar"

We cannot find any documentation/instructions/guide on how to setup the limits for thanos-sidecar, because changing "resources" in the monitoringstack yaml only changes the limits for PROMETHEUS pods, but not thanos-sidecar.

Additionally, in our case we don't even need thanos-sidecar and would like to disable it completely like we can disable "alertmanager".

Thank you!

@simonpasquier
Copy link
Contributor

You should be able to patch the Prometheus resource controlled by the MonitoringStack resource following this page: https://github.com/rhobs/observability-operator/blob/main/docs/user-guides/server-side-apply.md

Additionally, in our case we don't even need thanos-sidecar and would like to disable it completely like we can disable "alertmanager".

The reason why COO automatically deploys a Thanos sidecar is to support integration with the ThanosQuerier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants