-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COO-485: feat: deploy PrometheusRule resource #629
Conversation
@simonpasquier: This pull request references COO-485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
e93dcff
to
f99e588
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold I want to check manually that the rule is properly deployed. |
/hold cancel |
/hold |
7aa1930
to
02d1ee4
Compare
This change deploys a PrometheusRule resource with one alerting rule firing when one controller hits more than 10% of failed reconciliations in the last 5 minutes for more than 15 minutes. It also removes "legacy" monitoring resources which were part of the initial attempt to monitor the cluster observability operator but that effort was never finalized. Signed-off-by: Simon Pasquier <[email protected]>
02d1ee4
to
fd64aa7
Compare
oh nice, thanks! Unhold at will |
/hold cancel |
This change deploys a PrometheusRule resource with one alerting rule firing when one controller hits more than 10% of failed reconciliations in the last 5 minutes for more than 15 minutes.