Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COO-485: feat: deploy PrometheusRule resource #629

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

simonpasquier
Copy link
Contributor

This change deploys a PrometheusRule resource with one alerting rule firing when one controller hits more than 10% of failed reconciliations in the last 5 minutes for more than 15 minutes.

@simonpasquier simonpasquier requested a review from a team as a code owner November 18, 2024 13:53
@simonpasquier simonpasquier requested review from jan--f and PeterYurkovich and removed request for a team November 18, 2024 13:53
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 18, 2024

@simonpasquier: This pull request references COO-485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

This change deploys a PrometheusRule resource with one alerting rule firing when one controller hits more than 10% of failed reconciliations in the last 5 minutes for more than 15 minutes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

/hold

I want to check manually that the rule is properly deployed.

@simonpasquier
Copy link
Contributor Author

/hold cancel

@simonpasquier
Copy link
Contributor Author

/hold
we need to clean up the legacy PrometheusRule resources.

This change deploys a PrometheusRule resource with one alerting rule
firing when one controller hits more than 10% of failed reconciliations
in the last 5 minutes for more than 15 minutes.

It also removes "legacy" monitoring resources which were part of the
initial attempt to monitor the cluster observability operator but that
effort was never finalized.

Signed-off-by: Simon Pasquier <[email protected]>
@jan--f
Copy link
Collaborator

jan--f commented Nov 19, 2024

oh nice, thanks! Unhold at will
/lgtm

@simonpasquier
Copy link
Contributor Author

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit a63fe12 into rhobs:main Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants