From 673a991458b2e685896271fce3b69e8f10d0e4ed Mon Sep 17 00:00:00 2001 From: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com> Date: Wed, 21 Feb 2024 14:56:35 -0800 Subject: [PATCH] Add google protos to buildbucket update version, deps (#3493) A couple of changes added for buildbucket support: * Add the supporting well known Google protos so buildbucket objects can be instantiated. * Add short instructions on developing changes locally before pushing the library to pub.dev. * Re-pin versions as per: https://github.com/flutter/flutter/issues/110272 *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* --- packages/buildbucket-dart/CHANGELOG.md | 8 ++++++++ packages/buildbucket-dart/README.md | 11 +++++++++++ packages/buildbucket-dart/lib/buildbucket_pb.dart | 11 +++++++++-- packages/buildbucket-dart/pubspec.yaml | 4 ++-- 4 files changed, 30 insertions(+), 4 deletions(-) diff --git a/packages/buildbucket-dart/CHANGELOG.md b/packages/buildbucket-dart/CHANGELOG.md index b1677c8c0..1e58c4002 100644 --- a/packages/buildbucket-dart/CHANGELOG.md +++ b/packages/buildbucket-dart/CHANGELOG.md @@ -1,3 +1,11 @@ +# 1.0.9 + +- Pin versions due to https://github.com/flutter/flutter/issues/110272 + +# 1.0.8 + +- Update dependencies. + # 1.0.7 - Expose the google.protobuf dependency objects. diff --git a/packages/buildbucket-dart/README.md b/packages/buildbucket-dart/README.md index 3fa2a19d0..d33206651 100644 --- a/packages/buildbucket-dart/README.md +++ b/packages/buildbucket-dart/README.md @@ -14,6 +14,17 @@ These protobufs are used to communicate with LUCI Buildbucket services from Dart That will checkout protobuf, buildbucket and googleapis repositories. It will also compile the protos and generate their correspondent Dart classes. +## Validating Changes + +In order to validate the changes you have made before releasing a new version you can point your project +to the local directory for packages/buildbucket-dart by doing the following in your project's pubspec.yaml: + +```dart + dependencies: + buildbucket-dart: + path: /your/path/to/packages/buildbucket-dart +``` + ## Feedback File an issue in flutter/flutter with the word 'buildbucket-dart' clearly in the title and cc @godofredoc. diff --git a/packages/buildbucket-dart/lib/buildbucket_pb.dart b/packages/buildbucket-dart/lib/buildbucket_pb.dart index 7a67646f2..e2adb9379 100644 --- a/packages/buildbucket-dart/lib/buildbucket_pb.dart +++ b/packages/buildbucket-dart/lib/buildbucket_pb.dart @@ -46,8 +46,6 @@ export 'src/generated/go.chromium.org/luci/buildbucket/proto/builds_service.pb.d ScheduleBuildRequest_Swarming, StartBuildRequest, StartBuildResponse, - StartBuildTaskRequest, - StartBuildTaskResponse, CancelBuildRequest, CreateBuildRequest, SynthesizeBuildRequest, @@ -78,3 +76,12 @@ export 'src/generated/go.chromium.org/luci/buildbucket/proto/common.pb.dart' export 'src/generated/go.chromium.org/luci/buildbucket/proto/common.pbenum.dart'; export 'src/generated/go.chromium.org/luci/buildbucket/proto/notification.pb.dart' show NotificationConfig, BuildsV2PubSub, PubSubCallBack; + +export 'src/generated/google/protobuf/struct.pb.dart' show Struct, Value, Value_Kind, NullValue, ListValue; +export 'src/generated/google/protobuf/any.pb.dart' show Any; +export 'src/generated/google/protobuf/duration.pb.dart' show Duration; +export 'src/generated/google/protobuf/empty.pb.dart' show Empty; +export 'src/generated/google/protobuf/timestamp.pb.dart' show Timestamp; +export 'src/generated/google/protobuf/wrappers.pb.dart' + show DoubleValue, FloatValue, Int32Value, Int64Value, BoolValue, BytesValue, UInt32Value, UInt64Value, StringValue; +export 'src/generated/google/protobuf/field_mask.pb.dart' show FieldMask; diff --git a/packages/buildbucket-dart/pubspec.yaml b/packages/buildbucket-dart/pubspec.yaml index d1465225d..99d9a0e47 100644 --- a/packages/buildbucket-dart/pubspec.yaml +++ b/packages/buildbucket-dart/pubspec.yaml @@ -1,6 +1,6 @@ name: buildbucket description: LUCI Buildbucket library. Protos and utilities to communicate with LUCI buildbucket service. -version: 1.0.6 +version: 1.0.9 repository: https://github.com/flutter/cocoon/tree/main/packages/buildbucket-dart environment: @@ -14,4 +14,4 @@ dependencies: dev_dependencies: lints: 3.0.0 - test: 1.24.8 + test: 1.25.2