From 9dd49cd93309b4d737d244e34d699f448e6ef17b Mon Sep 17 00:00:00 2001 From: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com> Date: Tue, 9 Apr 2024 18:28:17 -0700 Subject: [PATCH] Remove unused maxCommits getter (#3633) Pull request removes an unused getter but is meant to test buildbucket v2 through postsubmit. Wait to merge. *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* --- app_dart/lib/src/service/config.dart | 2 -- app_dart/test/src/datastore/fake_config.dart | 3 --- 2 files changed, 5 deletions(-) diff --git a/app_dart/lib/src/service/config.dart b/app_dart/lib/src/service/config.dart index a338cdeaf..fd0f7c23d 100644 --- a/app_dart/lib/src/service/config.dart +++ b/app_dart/lib/src/service/config.dart @@ -299,8 +299,6 @@ class Config { 'flutter-dashboard@appspot.gserviceaccount.com', }; - int get maxTaskRetries => 2; - /// Max retries for Luci builder with infra failure. int get maxLuciTaskRetries => 2; diff --git a/app_dart/test/src/datastore/fake_config.dart b/app_dart/test/src/datastore/fake_config.dart index 712210a8a..aa9c12d66 100644 --- a/app_dart/test/src/datastore/fake_config.dart +++ b/app_dart/test/src/datastore/fake_config.dart @@ -136,9 +136,6 @@ class FakeConfig implements Config { @override Duration get githubRequestDelay => githubRequestDelayValue ?? Duration.zero; - @override - int get maxTaskRetries => maxTaskRetriesValue!; - /// Size of the shards to send to buildBucket when scheduling builds. @override int get schedulingShardSize => 5;