From a185ff907b019f8b2656ca5303f22e867a64ec63 Mon Sep 17 00:00:00 2001 From: Kate Lovett Date: Wed, 28 Feb 2024 18:10:50 -0600 Subject: [PATCH] Disable flaky golden file test (#144351) Filed https://github.com/flutter/flutter/issues/144350 for follow up. This test has become flaky and is breaking the tree. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes --- .../test/widgets/text_magnifier/text_magnifier.0_test.dart | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/api/test/widgets/text_magnifier/text_magnifier.0_test.dart b/examples/api/test/widgets/text_magnifier/text_magnifier.0_test.dart index 31cd7a47f2323..2d7df02c9a1fd 100644 --- a/examples/api/test/widgets/text_magnifier/text_magnifier.0_test.dart +++ b/examples/api/test/widgets/text_magnifier/text_magnifier.0_test.dart @@ -94,7 +94,10 @@ void main() { find.byType(example.TextMagnifierExampleApp), matchesGoldenFile('text_magnifier.0_test.png'), ); - }, variant: const TargetPlatformVariant({ TargetPlatform.iOS, TargetPlatform.android })); + }, + variant: const TargetPlatformVariant({ TargetPlatform.iOS, TargetPlatform.android }), + skip: true, // This image is flaky. https://github.com/flutter/flutter/issues/144350 + ); testWidgets('should show custom magnifier in RTL', (WidgetTester tester) async {