Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Variables from EBTEL2 (IDL version) #6

Open
chhabrasherry opened this issue Sep 14, 2022 · 4 comments
Open

Output Variables from EBTEL2 (IDL version) #6

chhabrasherry opened this issue Sep 14, 2022 · 4 comments

Comments

@chhabrasherry
Copy link

This may be a known problem, but I noticed that the listed outputs from EBTEL2.pro need to be written in order. If one tries to only get selected outputs (by name), the routine returns wrong outputs.

For example:
The initial calling sequence is written as (original ebtel2.pro):

ebtel2, ttime, heat, length, t, n, p, v, ta, na, pa, c11, dem_tr, dem_cor, $
logtdem, f_ratio, rad_ratio, cond, rad_cor,$
classical=classical, dynamic=dynamic, dem_old=dem_old, $
flux_nt=flux_nt, energy_nt=energy_nt, rtv=rtv, $
a_c=a_c, a_0=a_0, a_tr=a_tr, l_fact=l_fact

  • Note the order of output variables*

Now, If I need dem_tr, dem_cor and logtdem as outputs, and I use the following command (shown as an example in the routine):
ebtel2, ttime, heat, t, n, p, v, dem_tr, dem_cor, logtdem

It will return ta, na, pa for dem_tr, dem_cor, and logtdem. i.e. one cannot skip specific output variables.

This is not clarified anywhere in the document, so it causes a lot of confusion. Also, I was wondering if there is a way to fix it.

@chhabrasherry chhabrasherry changed the title Output from EBTEL2 (IDL version) Output Variables from EBTEL2 (IDL version) Sep 14, 2022
@wtbarnes wtbarnes transferred this issue from rice-solar-physics/ebtelplusplus Sep 15, 2022
@wtbarnes
Copy link
Member

wtbarnes commented Sep 15, 2022

Hi Sherry. I've moved this issue to the EBTEL repository. ebtelplusplus is the C++ code. Hope that is ok!

Thanks for bringing this up. I have to admit I was not aware of this at all as I've not really used the IDL code much, particularly with the DEM outputs.

So just to clarify, in the documentation, you're saying that the calling sequence for computing the DEM variables should instead be

ebtel2, ttime, heat, length, t, n, p, v, ta, na, pa, c11, dem_tr, dem_cor, logtdem

It looks like this affects both the first and fourth code examples in the documentation.

@chhabrasherry
Copy link
Author

chhabrasherry commented Sep 15, 2022 via email

@wtbarnes
Copy link
Member

Ok, I can easily amend the README to reflect that.

Do you know if there is an easier way to provide access to those optional variables, e.g. if I want dem_cor and logtdem, can I get those without having to list out all of those variables before them? Maybe through the use of keywords?

I'm not sure of the best way to do that or if it is possible. I'm really showing my IDL ignorance here...

@chhabrasherry
Copy link
Author

chhabrasherry commented Sep 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants