Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inputs to HeatingEvent #116

Open
wtbarnes opened this issue Oct 10, 2024 · 0 comments
Open

Refactor inputs to HeatingEvent #116

wtbarnes opened this issue Oct 10, 2024 · 0 comments
Labels
heating Issues related to generating heating events or models refactor

Comments

@wtbarnes
Copy link
Member

Because of the constraints on the shape of any heating event, it probably makes sense to refactor the inputs to be

  • time_start
  • duration
  • duration_rise
  • duration_decay

and then calculate rise_start, rise_end, decay_start, decay_end from these times. This should make it much easier to specify an even since the only absolute time one would need to calculate is time_start.
@wtbarnes wtbarnes added heating Issues related to generating heating events or models refactor labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
heating Issues related to generating heating events or models refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wtbarnes