Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple instances of "add_source" does not work #58

Open
ghost opened this issue Aug 26, 2020 · 2 comments
Open

multiple instances of "add_source" does not work #58

ghost opened this issue Aug 26, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 26, 2020

When I include multiple instances of "add_source" in the dispersion models, only the last instance is included in the output. The workaround has been to do each in its own call to run_model(), but that seems inefficient.

@AlFontal
Copy link

Hey @kpmessier, I don't know if this was changed after you mentioned your issue, but what the code seems to do now is to generate a single CONTROL file for each source, and iterate over the run_model() once for each source.

It's really inefficient for sure... At least compared to running it with the GUI with a single CONTROL file, which the syntax allows. I might try to change it in a PR but I am crazy busy right now...

Did you find any solution to the issue seeing that you posted it almost 3 years ago?

@kyle-messier
Copy link

Hi @AlFontal Due to the inactivity of this package, I was forced to explore other options. I have a postdoc working with me on scalable dispersion (and advection) modeling with PINNs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants