Merge pull request #1553 from riganti/fix/bp-breakingchange-validator

Fixed issue in `Validator` in connection with BP
riganti · Jan 20, 2023 · 01aafd5 · 01aafd5
2 parents 477bf10 + 0ee2368
commit 01aafd5
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/Framework/Framework/Controls/Validator.cs b/src/Framework/Framework/Controls/Validator.cs
@@ -99,7 +99,15 @@ private static void AddValidatedValue(IHtmlWriter writer, IDotvvmRequestContext
             }
             else
             {
-                throw new DotvvmControlException($"Could not resolve {nameof(ValueProperty)} to a valid value binding.");
+                // Note: ValueProperty can sometimes contain null (BusinessPack depends on this behaviour)
+                // However, it certainly should not contain hard-coded values
+
+                var valueRaw = control.GetValueRaw(ValueProperty);
+                if (valueRaw != null)
+                {
+                    // There is a hard-coded value in the ValueProperty
+                    throw new DotvvmControlException($"{nameof(ValueProperty)} can not contain a hard-coded value.");
+                }
             }
 
             // render options