-
Notifications
You must be signed in to change notification settings - Fork 97
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix leaking of original object from ko.observableArray
ko.observableArray would leak the original object to its 'arrayChanges' subscribers when instance method (such as 'push', 'splice') was used to modify the array. Knockout would pre-compute the diff passed to the subscribers before our validator was called. * Knockout updated to b7b150a6 to remove an optimization which was the primary cause * Made FakeObservableObject internal properties non-enumerable so make sure they don't propagate through coercer when assigned into an array.
- Loading branch information
Showing
4 changed files
with
246 additions
and
187 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.