Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Obsolete attribute from RegisterScriptModule #1889

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Remove Obsolete attribute from RegisterScriptModule #1889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Framework/Framework/ResourceManagement/ResourceRepositoryExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public static LinkResourceBase RegisterScriptFile(
/// <summary> Registers a <see cref="ScriptModuleResource" /> from the specified file.
/// The file can be anywhere in the filesystem, it does not have to be in the wwwroot folder.
/// DotVVM will handle its serving, caching, ... automatically </summary>
[Obsolete("<script type='module'> is always deferred, the attribute does nothing")]
public static LinkResourceBase RegisterScriptModuleFile(
this DotvvmResourceRepository repo,
string name,
Expand All @@ -88,7 +87,7 @@ public static LinkResourceBase RegisterScriptModuleFile(
/// <summary> Registers a <see cref="ScriptModuleResource" /> from the specified file.
/// The file can be anywhere in the filesystem, it does not have to be in the wwwroot folder.
/// DotVVM will handle its serving, caching, ... automatically </summary>
[Obsolete("<script type='module'> is always deferred, the attribute does nothing")]
[Obsolete("<script type='module'> is always deferred, the attribute does nothing. Please remove the defer parameter.")]
public static LinkResourceBase RegisterScriptModuleFile(
this DotvvmResourceRepository repo,
string name,
Expand Down
Loading