Replace javax servlet classes with Jakarta servlet #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This should be okay, as the javax servlets are deprecated in pretty much everything, and Lein-Ring is not 1.0 so there's no guarantee of backward compatibility. That said, if someone complains we can always put an option in to switch from one to the other. Have you tested this change? Does it produce a war file that runs under a servlet container? Also, can you change the commit message to: This will make it consistent with the other commits in the repository. |
Done.
Yes, tested on Tomcat 11. Works as expected. |
madoxas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ring-clojure/ring#517
Note: This is a breaking change!
I'm open for suggestions, if there's a need to support both javax and jakarta servlets in the code.