Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: convert Popup component to use new <dialog> HTML element #39

Open
franknoirot opened this issue May 14, 2022 · 0 comments
Open

Feat: convert Popup component to use new <dialog> HTML element #39

franknoirot opened this issue May 14, 2022 · 0 comments

Comments

@franknoirot
Copy link
Collaborator

franknoirot commented May 14, 2022

The newly-stable <dialog> element has a number of good features such as keyboard capture, support for deep nesting, and simple backdrop styling. After "one-for-one" migration to NextJS is complete, we should adopt this new dialog and simplify our Popup component considerably. It will also allow components that have associated popups to keep the popup dialogs next to them, instead of needing to be at the page level (at the bottom of the DOM no less), making understanding the codebase that much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant