Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual types with xrpl.js types #1129

Open
pdp2121 opened this issue Feb 19, 2025 · 0 comments
Open

Replace manual types with xrpl.js types #1129

pdp2121 opened this issue Feb 19, 2025 · 0 comments
Labels
cleanup This issue is for cleaning up existing code.

Comments

@pdp2121
Copy link
Collaborator

pdp2121 commented Feb 19, 2025

Replace manual types with xrpl.js types. For example:

export interface TransactionCommonFields {
date: string
Account: string
TransactionType: string
Fee: string
Sequence: number
AccountTxnID?: string
Flags?: number
LastLedgerSequence?: number
Memos?: Memo[]
Signers?: object[]
SourceTag?: number
SignerPubKey?: string
TicketSequence?: number
TxnSignature?: string
}

should be replaced with BaseTransaction. Similar things applied to fields such as:

export interface DIDDelete extends BaseTransaction {
TransactionType: 'DIDDelete'
}

@pdp2121 pdp2121 added the cleanup This issue is for cleaning up existing code. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup This issue is for cleaning up existing code.
Projects
None yet
Development

No branches or pull requests

1 participant