Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudo-Instructions are not differentiated in the dictionary #327

Open
AFOliveira opened this issue Nov 27, 2024 · 1 comment
Open

Pseudo-Instructions are not differentiated in the dictionary #327

AFOliveira opened this issue Nov 27, 2024 · 1 comment

Comments

@AFOliveira
Copy link
Contributor

Pseudo-instructions are not explicitly differentiated from real instructions in the generated instruction dictionary. Moreover they lack information about their origin (parent) instructions.
Although this might not be needed by most downstream repos, which I assume don't use pseudo instruction, the lack of differentiation makes it really hard when this information is needed. I think this could be solved by either creating a separate dictionary just for pseudo or of just by adding a 'is_pseudo' and a 'origin_instruction' to the dictionary. I'm more inclined to the second approach since it will only minimally affect the repo code base and ouputs.

@AFOliveira
Copy link
Contributor Author

I've made this downstream:

  "zip": {
    "encoding": "000010001111-----001-----0010011",
    "variable_fields": [
      "rd",
      "rs1"
    ],
    "extension": [
      "rv32_zks",
      "rv32_zkn",
      "rv32_zk",
      "rv32_zbkb"
    ],
    "match": "0x8f01013",
    "mask": "0xfff0707f",
    "is_pseudo": true,
    "parent": "shfli",
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant