Add Unit Tests for shared_utils.py #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Mohan <[email protected]>
Signed-off-by: Jay Dev Jha <[email protected]>
Signed-off-by: Jay Dev Jha <[email protected]>
|
@TraXIcoN I have fixed the issue and removed the label Looping @aswaterman and @rpsene also. Thanks @TraXIcoN for this PR and adding test cases for |
Closed
|
@TraXIcoN LGTM. Definitely it contains well organized test suites comprising both positive and negative test cases. Once you resolves with conflicts, comment here so that it could get merged. Let me know, if you run into an issue while fixing |
IIITM-Jay
reviewed
Nov 2, 2024
Signed-off-by: Jay Dev Jha <[email protected]>
Signed-off-by: Jay Dev Jha <[email protected]>
Signed-off-by: Jay Dev Jha <[email protected]>
IIITM-Jay
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
@TraXIcoN I have resolved the conflicts and fixed the pyright issues. Actually, the pre-commit tool for this repo is now also includes the pyright hooks. So, some changes were needed for test suites too, I have done the necessary changes accordingly.
@aswaterman requesting your feedback and an overview for this PR, and then I think this PR is good to be merged.
Thanks once again @TraXIcoN for the tests and @aswaterman for your extreme support!
Signed-off-by: Jay Dev Jha <[email protected]>
aswaterman
approved these changes
Nov 4, 2024
Myrausman
pushed a commit
to Myrausman/riscv-opcodes
that referenced
this pull request
Nov 14, 2024
* Added test cases for shared_utils Signed-off-by: Aditya Mohan <[email protected]> * Added definition for logging an error shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Pre-commit fixes for shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * pyright fixes for test.py Signed-off-by: Jay Dev Jha <[email protected]> * Minor changes to shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Updated test.py Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Aditya Mohan <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
Myrausman
pushed a commit
to Myrausman/riscv-opcodes
that referenced
this pull request
Nov 14, 2024
* Added test cases for shared_utils Signed-off-by: Aditya Mohan <[email protected]> * Added definition for logging an error shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Pre-commit fixes for shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * pyright fixes for test.py Signed-off-by: Jay Dev Jha <[email protected]> * Minor changes to shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Updated test.py Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Aditya Mohan <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
Myrausman
pushed a commit
to Myrausman/riscv-opcodes
that referenced
this pull request
Nov 14, 2024
* Added test cases for shared_utils Signed-off-by: Aditya Mohan <[email protected]> * Added definition for logging an error shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Pre-commit fixes for shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * pyright fixes for test.py Signed-off-by: Jay Dev Jha <[email protected]> * Minor changes to shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Updated test.py Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Aditya Mohan <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
Myrausman
pushed a commit
to Myrausman/riscv-opcodes
that referenced
this pull request
Nov 14, 2024
* Added test cases for shared_utils Signed-off-by: Aditya Mohan <[email protected]> * Added definition for logging an error shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Pre-commit fixes for shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * pyright fixes for test.py Signed-off-by: Jay Dev Jha <[email protected]> * Minor changes to shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Updated test.py Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Aditya Mohan <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
Myrausman
pushed a commit
to Myrausman/riscv-opcodes
that referenced
this pull request
Nov 14, 2024
* Added test cases for shared_utils Signed-off-by: Aditya Mohan <[email protected]> * Added definition for logging an error shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Pre-commit fixes for shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * pyright fixes for test.py Signed-off-by: Jay Dev Jha <[email protected]> * Minor changes to shared_utils.py Signed-off-by: Jay Dev Jha <[email protected]> * Updated test.py Signed-off-by: Jay Dev Jha <[email protected]> --------- Signed-off-by: Aditya Mohan <[email protected]> Signed-off-by: Jay Dev Jha <[email protected]> Co-authored-by: Jay Dev Jha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the shared_utils.py module. It covers encoding utilities, bit manipulation, argument handling, ISA type validation, string manipulation, and instruction processing. These tests will help ensure the module works correctly and is easier to maintain.