Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved response when selecting or moving a piece #157

Open
riverwanderer opened this issue May 5, 2024 · 7 comments
Open

Improved response when selecting or moving a piece #157

riverwanderer opened this issue May 5, 2024 · 7 comments
Assignees
Labels
beta Report from a Beta release
Milestone

Comments

@riverwanderer
Copy link
Owner

Module V5.0.0beta8
Vassal V3.7.12

Piece movement is sometimes slow, especially when moving a piece during retreat phase.

@riverwanderer riverwanderer added the beta Report from a Beta release label May 5, 2024
@riverwanderer riverwanderer added this to the 5.0.0 milestone May 5, 2024
@riverwanderer riverwanderer self-assigned this May 5, 2024
@riverwanderer
Copy link
Owner Author

Attempted improvement by replacing hover-aid with a hint during retreat.

@riverwanderer
Copy link
Owner Author

Converting combat piece player aids to clickable (on unit) improves performance somewhat. Vassal PR#13440 may have also helped.

@riverwanderer riverwanderer modified the milestones: 5.0.0, 5.1.0 Jul 11, 2024
@riverwanderer
Copy link
Owner Author

Extensive use of calculated properties and equivalent Text Label or Layer expressions is the likely cause of delays.
The following pieces need to be worked through and converted to direct action-driven calculations using Dynamic Properties or Layer activation:

Leader (Side) Icons
Combat Assist Controller
Combat Assist Side Bar

Fix for Leader (Side) Icon Order display implemented in a809.

@riverwanderer
Copy link
Owner Author

Replaced auto-calculation of hand sizes in Side Icons in a810.

@github-project-automation github-project-automation bot moved this to Done in CCNap 5 Sep 9, 2024
@riverwanderer riverwanderer reopened this Sep 9, 2024
@riverwanderer riverwanderer changed the title Slow response when moving a piece Improved response when selecting or moving a piece Sep 9, 2024
@riverwanderer riverwanderer pinned this issue Sep 11, 2024
@riverwanderer
Copy link
Owner Author

Modified Combat Assist Controller to disable key layers unless gCombatSide is set. Complementary change to combatOver test in Leader Check. This also preserves side indication for Leader Check.
Fix in a816.

@riverwanderer
Copy link
Owner Author

Tested through to a828.

@riverwanderer
Copy link
Owner Author

Evaluate Sleep() techniques for providing visual feedback on acceptance of key actions:

  • ordering
  • combat marker placement
  • dice roll sequences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Report from a Beta release
Projects
Status: Done
Development

No branches or pull requests

1 participant