Remove legacy analysis help. (#4743)

rizinorg · Nov 27, 2024 · 4f7f6b7 · 4f7f6b7
1 parent 56d9cf5
commit 4f7f6b7
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 34 deletions.
diff --git a/librz/core/cmd/cmd_analysis.c b/librz/core/cmd/cmd_analysis.c
@@ -17,33 +17,6 @@
 
 HEAPTYPE(ut64);
 
-static const char *help_msg_a[] = {
-	"Usage:", "a", "[abdefFghoprxstc] [...]",
-	"a*", "", "same as afl*;ah*;ax*",
-	"aa", "[?]", "analyze all (fcns + bbs) (aa0 to avoid sub renaming)",
-	"a8", " [hexpairs]", "analyze bytes",
-	"ab", "[?] [addr]", "analyze block",
-	"ad", "[?]", "analyze data trampoline (wip)",
-	"ad", " [from] [to]", "analyze data pointers to (from-to)",
-	"ae", "[?] [expr]", "analyze opcode eval expression (see ao)",
-	"af", "[?]", "analyze Functions",
-	"aF", "", "same as above, but using analysis.depth=1",
-	"ag", "[?] [options]", "draw graphs in various formats",
-	"ah", "[?]", "analysis hints (force opcode size, ...)",
-	"ai", " [addr]", "address information (show perms, stack, heap, ...)",
-	"aj", "", "same as a* but in json (aflj)",
-	"aL", "", "list all asm/analysis plugins (e asm.arch=?)",
-	"an", " [name] [@addr]", "show/rename/create whatever flag/function is used at addr",
-	"ao", "[?] [len]", "analyze Opcodes (or emulate it)",
-	"aO", "[?] [len]", "Analyze N instructions in M bytes",
-	"ap", "", "find prelude for current offset",
-	"ar", "[?]", "like 'dr' but for the esil vm. (registers)",
-	"as", "[?] [num]", "analyze syscall using dbg.reg",
-	"av", "[?] [.]", "show vtables",
-	"ax", "[?]", "manage refs/xrefs (see also afx?)",
-	NULL
-};
-
 static const char *help_detail_ae[] = {
 	"Examples:", "ESIL", " examples and documentation",
 	"=", "", "assign updating internal flags",
@@ -1776,11 +1749,6 @@ RZ_IPI RzCmdStatus rz_analysis_global_variable_retype_handler(RzCore *core, int
 	return RZ_CMD_STATUS_OK;
 }
 
-RZ_API void rz_core_cmd_show_analysis_help(RZ_NONNULL RzCore *core) {
-	rz_return_if_fail(core);
-	rz_core_cmd_help(core, help_msg_a);
-}
-
 RZ_IPI RzCmdStatus rz_analysis_function_blocks_list_handler(RzCore *core, int argc, const char **argv, RzCmdStateOutput *state) {
 	RzAnalysisFunction *fcn = analysis_get_function_in(core->analysis, core->offset);
 	if (!fcn) {

diff --git a/librz/include/rz_core.h b/librz/include/rz_core.h
@@ -1330,7 +1330,6 @@ typedef bool (*RzCmdRegSync)(RzCore *core, RzRegisterType type, bool write);
 RZ_API bool rz_core_reg_assign_sync(RZ_NONNULL RzCore *core, RZ_NONNULL RzReg *reg, RzCmdRegSync sync_cb, RZ_NONNULL const char *name, ut64 val);
 RZ_API RZ_OWN RzList /*<RzRegItem *>*/ *rz_core_reg_filter_items_sync(RZ_NONNULL RzCore *core, RZ_NONNULL RzReg *reg, RzCmdRegSync sync_cb, RZ_NULLABLE const char *filter);
 
-RZ_API void rz_core_cmd_show_analysis_help(RZ_NONNULL RzCore *core);
 RZ_API void rz_core_rtr_enable(RZ_NONNULL RzCore *core, const char *cmdremote);
 
 RZ_API RZ_OWN char *rz_core_analysis_var_to_string(RZ_NONNULL RzCore *core, RZ_NONNULL RzAnalysisVar *var);

diff --git a/librz/main/rizin.c b/librz/main/rizin.c
@@ -1410,7 +1410,7 @@ RZ_API int rz_main_rizin(int argc, const char **argv) {
 		case 1: rz_core_perform_auto_analysis(r, RZ_CORE_ANALYSIS_SIMPLE); break;
 		case 2: rz_core_perform_auto_analysis(r, RZ_CORE_ANALYSIS_DEEP); break;
 		case 3: rz_core_perform_auto_analysis(r, RZ_CORE_ANALYSIS_EXPERIMENTAL); break;
-		default: rz_core_cmd_show_analysis_help(r); break;
+		default: break;
 		}
 		rz_cons_flush();
 	}