Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up x86_il.c #3864

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Split up x86_il.c #3864

merged 3 commits into from
Sep 15, 2023

Conversation

DMaroo
Copy link
Member

@DMaroo DMaroo commented Sep 15, 2023 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Split x86_il.c into common.c for the utility functions and helpers and il_ops.inc for the IL ops implementation
  • Now the x86_il.c file only contains the instruction to IL op mapping and the IL plugin
  • This is needed for adding more instructions, which now can be easily added by creating a new ".inc" file

Test plan

Existing tests should pass.

Closing issues

None, this is just a refactor. Will make it easier to add IL for floating-point instructions (#3861).

@DMaroo
Split up x86_il.c
9a6aa1c 
    * Split `x86_il.c` into `common.c` for the utility functions and
      helpers and `il_ops.inc` for the IL ops implementation
    * Now the `x86_il.c` file only contains the instruction to IL op
      mapping and the IL plugin
    * This is needed for adding more instructions, which now can be
      easily added by creating a new ".inc" file
@DMaroo DMaroo requested a review from thestr4ng3r as a code owner September 15, 2023 11:46
@DMaroo DMaroo added X86 refactor Refactoring requests RZIL labels Sep 15, 2023
@DMaroo DMaroo mentioned this pull request Sep 15, 2023
Merged
5 tasks
@DMaroo
Copy link
Member Author

DMaroo commented Sep 15, 2023

Merging this for #3865.

@DMaroo DMaroo merged commit e95650f into dev Sep 15, 2023
44 checks passed
@DMaroo DMaroo deleted the x86-il-file-split branch September 15, 2023 14:29
vlasel pushed a commit to vlasel/rizinorg-rizin that referenced this pull request Sep 16, 2023
@DMaroo
Split up x86_il.c (rizinorg#3864)
cb372e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
refactor Refactoring requests RzAnalysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMaroo @XVilka