Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition of strings in RzBinPlugin (from list to pvector) #4052

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Transition of strings in RzBinPlugin (from list to pvector) #4052

merged 1 commit into from
Jan 4, 2024

Conversation

PeiweiHu
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

CI is green.

Closing issues

partially address #3775

@wargio
Copy link
Member

wargio commented Dec 29, 2023 •
edited
Loading

looks like you broke something in the string part.

@PeiweiHu
Copy link
Contributor Author

looks like you broke something in the string part.

Thank you. I will fix it later.

@wargio
Copy link
Member

wargio commented Jan 3, 2024

Please modify rz_pvector_len and allow it to accept nullptr and return 0

XVilka
XVilka approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@XVilka XVilka merged commit b43fe31 into rizinorg:dev Jan 4, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
API DEX ELF java Mach-O PE rz-bin rz-diff rz-find rz-test RzBin RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeiweiHu @wargio @XVilka