Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static and global variables in disasm and analysis #4063

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Remove static and global variables in disasm and analysis #4063

merged 2 commits into from
Jan 3, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Jan 3, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Remove mutable static/global variables and reuse RzAnalysisEsilInterState introduced earlier.

Test plan

CI is green

Closing issues

Partially addresses #4055

@XVilka XVilka force-pushed the asan-fix-globals branch 2 times, most recently from 25d259a to 2108ffa Compare January 3, 2024 14:31
@XVilka XVilka changed the title Remove static and global varibles in disasm.c Remove static and global varibles in disasm and analysis Jan 3, 2024
@XVilka XVilka changed the title Remove static and global varibles in disasm and analysis Remove static and global variables in disasm and analysis Jan 3, 2024
@XVilka XVilka force-pushed the asan-fix-globals branch 2 times, most recently from 3cf9786 to 0f34c31 Compare January 3, 2024 15:45
@XVilka XVilka merged commit 2b0de30 into dev Jan 3, 2024
47 checks passed
@XVilka XVilka deleted the asan-fix-globals branch January 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
API RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XVilka