Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve some signed int issues in json output #4094

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

marcograss
Copy link
Contributor

@marcograss marcograss commented Jan 11, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

There was a bug in json output where I was receiving offsets that were negative because of a signed issue in rizin, I went and correct them

Test plan

I tested on the code I was running

Closing issues

...

@XVilka XVilka merged commit cc696d3 into rizinorg:dev Jan 11, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants