Fix windows debug plugin #4099
Merged
Fix windows debug plugin #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
approved these changes
Jan 12, 2024
| @@ -809,7 +809,7 @@ static void add_library(DWORD pid, LPVOID lpBaseOfDll, HANDLE hFile, char *dllna | |||
| } | |||
|
|
|||
| static void *last_library(void) { | |||
| return rz_list_get_tail_data(lib_list); | |||
| return lib_list ? rz_list_get_tail_data(lib_list) : NULL; | |||
There was a problem hiding this comment.
Uh. Globals...
Not in this PR though. Thanks for the fix!
|
when should it be ready please? I need it for work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
No longer loads the windows library file when it doesn't exist.
#3625 (comment)
Test plan
...
Closing issues
...