Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librz/arch/alpha: build only for Capstone > 5 #4735

Merged
merged 1 commit into from
Nov 24, 2024
Merged

librz/arch/alpha: build only for Capstone > 5 #4735

merged 1 commit into from
Nov 24, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Nov 24, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Fix Capstone 4 and 5 building:

FAILED: librz/arch/librz_arch.so.0.8.0.p/p_arch_alpha.c.o 
gcc -Ilibrz/arch/librz_arch.so.0.8.0.p -I. -I.. -Ilibrz -I../librz -Ilibrz/include -I../librz/include -I../librz/arch/isa -I../librz/arch/isa_gnu -Ilibrz/arch -I../librz/arch -Ilibrz/util/sdb/src -I../librz/util/sdb/src -I../librz/bin/format -I../librz/type/parser -I../subprojects/capstone-4.0.2/include -I../subprojects/capstone-4.0.2/include/capstone -Isubprojects/rzspp -I../subprojects/rzspp -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -DCC_SUPPORTS_W_ENUM_CONVERION -DCC_SUPPORTS_W_ENUM_COMPARE --std=gnu99 -Werror=sizeof-pointer-memaccess -Wimplicit-fallthrough=3 -fvisibility=hidden -DRZ_PLUGIN_INCORE=1 -DSUPPORTS_PCRE2_JIT -D_GNU_SOURCE -fPIC -MD -MQ librz/arch/librz_arch.so.0.8.0.p/p_arch_alpha.c.o -MF librz/arch/librz_arch.so.0.8.0.p/p_arch_alpha.c.o.d -o librz/arch/librz_arch.so.0.8.0.p/p_arch_alpha.c.o -c ../librz/arch/p/arch_alpha.c
In file included from ../librz/arch/p/arch_alpha.c:6:
../librz/arch/p/analysis/analysis_alpha_cs.c:10:10: fatal error: capstone/alpha.h: No such file or directory
   10 | #include <capstone/alpha.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

Test plan

CI is green

Closing issues

...

@XVilka XVilka requested a review from wargio as a code owner November 24, 2024 13:33
@XVilka XVilka merged commit ad4e1cd into dev Nov 24, 2024
56 of 58 checks passed
@XVilka XVilka deleted the dist-alpha-arch branch November 24, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant