Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
I've finally realized that the likely reason for the
binrz/rz-test/
requirement inrz_test_chdir()
is that it assumes an in-source (or in-tree) build, where binaries are placed next to their source when building. Meson only allows out-of-source (or out-of-tree) builds, and additionally we have ameson install
step, so the final location of Rizin binaries can't really be used to find the Rizin test dirs.Thus, this pr removes the not-relevant-to-us
rz_test_chdir()
code, with the extra benefit that adding./
to a test filename doesn't result in surprising behavior (as noted in #4759). I've added extra details to therz_test_chdir_fromtest()
Doxygen comment since the code can fall back to the current working directory if a test filename isn't provided i.e.rz-test
is invoked without an argument.Test plan
The above makes sense and there are no significant regressions like what is described in #4759. All builds are green.
Closing issues
...