Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App distribution #32

Open
fajarnuha opened this issue Mar 17, 2020 · 9 comments
Open

App distribution #32

fajarnuha opened this issue Mar 17, 2020 · 9 comments

Comments

@fajarnuha
Copy link
Collaborator

fajarnuha commented Mar 17, 2020

its still disappointing our apps is suspended because of Google doesn't want any covid related app in playstore
lets figure out the best way the other can take benefit from this app

@rizmaulana said he has an idea to distribute in Firebase app distribution
lets discuss

@rizmaulana
Copy link
Owner

rizmaulana commented Mar 17, 2020

It is something like this mas @fajarnuha https://proandroiddev.com/devops-understanding-and-applying-ci-cd-pipeline-for-android-developers-part-2-ec5b063c01bc

I already configured on my local machine and enable fastlane to distribute to Firebase, but I face some issue when want to apply into Github CI/CD :

  1. How to store Google API Keys while our repo is public repo
  2. How to store signing key of the app
  3. How to attach analytic only on release version
    It seems need more powerful CI/CD than Github action, like Jenkins maybe 😅 Any Idea?

@pandubaraja
Copy link
Collaborator

pandubaraja commented Mar 17, 2020

Nice question @rizmaulana

I think we should have another repository for tackling question number 1 and 2

Actually we can push commit to multiple repositories. Now the question is can we specified rule inside .gitignore specified for each repository? e.g. on public repo ignore api key and jks file and on private repo don't ignore it.

Here's something to read about one project has multiple repositories
Refs: https://stackoverflow.com/questions/11690709/can-a-project-have-multiple-origins/11690868

@fajarnuha fajarnuha reopened this Mar 18, 2020
@fajarnuha
Copy link
Collaborator Author

usually CI/CD have some kind of mechanism to store secret value. doesnt fastlane/github action have it?

having 2 repos will complicate things for this kind of project i think...

for the sake of simplicity lets ignore analytics hit even on debug, we can filter by version number if we want to see release version only

@pandubaraja
Copy link
Collaborator

usually CI/CD have some kind of mechanism to store secret value. doesnt fastlane/github action have it?

having 2 repos will complicate things for this kind of project i think...

for the sake of simplicity lets ignore analytics hit even on debug, we can filter by version number if we want to see release version only

@fajarnuha you're right about having 2 repos will complicate things cannot find how to do it in the right way too, we can ignore that idea.

This article below can be a good read to start implementing secrets with Github Action
https://help.github.com/en/actions/configuring-and-managing-workflows/using-variables-and-secrets-in-a-workflow

@fajarnuha
Copy link
Collaborator Author

just come into my mind, can we use Github release for the start? what do you guys think?
image

@pandubaraja
Copy link
Collaborator

Good idea! Let use release and tag, with this we can list all features shipped on each version as documentation.

@rizmaulana
Copy link
Owner

Good ideas mas @pandubaraja @fajarnuha we can start for next release to implement this APi : https://indonesia-covid-19-api.now.sh/api

@fajarnuha
Copy link
Collaborator Author

nice finding @rizmaulana lets do it!! ill create the issue and lets discuss there

@fajarnuha
Copy link
Collaborator Author

nice finding @rizmaulana lets do it!! ill create the issue and lets discuss there

see #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants