Refactor the code and move some functions into class methods #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bachibouzouk
force-pushed
the
feature/refactor-code
branch
from
042bef3 to
eb47df5
Compare
Bachibouzouk
changed the title
Bachibouzouk
force-pushed
the
feature/refactor-code
branch
from
41f39c9 to
79b72ab
Compare
Bachibouzouk
changed the title
Bachibouzouk
force-pushed
the
feature/refactor-code
branch
4 times, most recently
from
add32f0 to
5353911
Compare
Bachibouzouk
force-pushed
the
feature/import-export
branch
2 times, most recently
from
a98e3b5 to
99abb79
Compare
Bachibouzouk
force-pushed
the
feature/refactor-code
branch
2 times, most recently
from
e1bf722 to
e428d1e
Compare
Bachibouzouk
force-pushed
the
feature/refactor-code
branch
from
e428d1e to
c154922
Compare
…port Use a spreadsheet as input file as an alternative to .py files
- Mapping between old and new parameters in file constants.py - Move the class Appliance outside of User class
Provide two ways to define power timeseries
Move the peak time frame calculation within a function to allow for unittesting. Use maximum_profile instead of the misleading window_curve. A User instance maximum_profile constists of the aggregation of its Appliance instances maximum_profiles Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Identifies a random switch on time within the available functioning windows Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Also assign the random cycles to an attribute of the appliance Co-authored-by: Gokarna.Dhungel <[email protected]>
Also explicitely assign attributes in __init__ method of Appliance class Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Stress the relations between variables and equations of the seminal paper and the code with comments Co-authored-by: Gokarna.Dhungel <[email protected]>
The method is called generate_profile and update the daily_use attribute Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Co-authored-by: Gokarna.Dhungel <[email protected]>
Enhance code readability and decrease risk of errors by typos Co-authored-by: Gokarna.Dhungel <[email protected]>
Add further quotes to the seminal paper in the docstrings
Move the code which determines whether the indexes are within or out of the peak window outside the function, so it makes the argument of the method more meaningful
Co-authored-by: Gokarna.Dhungel <[email protected]>
One to define a duty_cycle and the otherone to choose between two duty cycles
Bachibouzouk
force-pushed
the
feature/refactor-code
branch
from
c154922 to
99175f1
Compare
|
This PR is now replaced by RAMP-project#36 |
Bachibouzouk
pushed a commit
that referenced
this pull request
Sep 28, 2022
Update stochastic_process.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
@dhungelgd I will move your changes into this PR as I go over the review of #4
This should constitute the next PR on the original RAMP repository, as soon as RAMP-project#34 is merged