Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style scenario box #49

Open
nesnoj opened this issue Jan 6, 2025 · 15 comments
Open

Style scenario box #49

nesnoj opened this issue Jan 6, 2025 · 15 comments

Comments

@nesnoj
Copy link
Member

nesnoj commented Jan 6, 2025

Breathe beauty into scenario box. Should contain:

  • title
  • heating technology / technologies
    • there is always 1 main tech, e.g. "Fernwärme", "BHKW" , "Erdwärmepumpe"
    • additional heating can be added, e.g. combination "Erdwärmepumpe"+"Heizstab"+"Solarthermie"
    • max. number of simultaneously shown tech/icons is 5
    • use icons from Add scenario icons #48
  • renovation measures, max. number of simultaneously shown tech/icons is 4, icons from Add scenario icons #48
  • delete button (implemented)
  • edit button (being implemented in small fixes #45)

First draft from figma:
image

@bmlancien
Copy link
Collaborator

Here a draft with 2 variants for the scenario box. Basically the second one is the same but the edit and delete actions are hidden behind the more button at the top right corner (personally, my favorite).

Scenario box

@nesnoj
Copy link
Member Author

nesnoj commented Jan 7, 2025

Thx for the draft, I prefer the 2nd one too 😍

On the layout: The user can create up to 3 scenarios which sum up to a max of 27 items - maybe too many in the vertical space? What do you think about a more compact design?

For example:
image

or alternatively:
image

In this case the icons should be fully self-explanatory..

@bmlancien
Copy link
Collaborator

I would be cautious about only using icons, even if they are more or less easy to identify. In our case we are dealing with icons that are not very common, so it's more difficult to understand at a glance what they are about. Usually it is better to have the label too. But if we want to do without visible labels, we should add them on hover. We can also give them the possibility to expand the boxes.

Scenario box

@nesnoj
Copy link
Member Author

nesnoj commented Jan 10, 2025

Yes, I understand your concern and I'm also a bit skeptical about the comprehensibility.
Maybe you could draft a scenario section from your first proposal with 3 scenarios holding 9 items each and see if there's a chance to fit into a vertical screen resolution sth. below full HD?

@bmlancien
Copy link
Collaborator

Maybe using something like a tag look, so they can also appear next to each other? It would probably still have a vertical scroll visible on smaller screens, but this is already more compact.

Scenario box

@nesnoj
Copy link
Member Author

nesnoj commented Jan 10, 2025

Yess, looks very nice, go for it!
I like the left, colored version :)
Arranging the elements in a grid instead of the tag layout might looked more clean, maybe worth a try..

@bmlancien
Copy link
Collaborator

Do you prefer with a grid?

Scenario box

@nesnoj
Copy link
Member Author

nesnoj commented Jan 13, 2025

Do you prefer with a grid?

Yes I do :)

@bmlancien
Copy link
Collaborator

@henhuy Is it possible to make the items inside the content as a list or divs so I can style them? Right now this is just plain text. Also good to have would be the category names.

@henhuy
Copy link
Contributor

henhuy commented Feb 10, 2025

@henhuy Is it possible to make the items inside the content as a list or divs so I can style them? Right now this is just plain text. Also good to have would be the category names.

@josihoppe could you take over?

@josihoppe
Copy link
Collaborator

josihoppe commented Feb 11, 2025

Yes I can do that. @bmlancien by list you mean putting the items in <ul> <li> item </li> </ul> structure? And would you prefer list or divs? :)

@bmlancien
Copy link
Collaborator

@josihoppe For accessibility purposes, I would go for the <ul> type. I just need to be able to specify css classes. But I guess I can do this on my own.
Something good would also to have <span>icon path</span><span>name</span> inside the list item, if possible :)

@josihoppe
Copy link
Collaborator

@josihoppe For accessibility purposes, I would go for the <ul> type. I just need to be able to specify css classes. But I guess I can do this on my own. Something good would also to have <span>icon path</span><span>name</span> inside the list item, if possible :)

will see what I can do :D

@josihoppe
Copy link
Collaborator

@bmlancien does #87 look the way you wanted it?

@bmlancien
Copy link
Collaborator

It looks good, thank you @josihoppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants