Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Facades of the different component we developp do not follow the same standard #28

Open
1 task
Bachibouzouk opened this issue Jul 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Bachibouzouk
Copy link
Contributor

Bachibouzouk commented Jul 10, 2024

Description of the issue

for example

from oemof_industry.mimo_converter import MIMO

differs from

from oemof_tabular_plugins.wefe.facades import MIMO

because in the latter we defined extra class methods in oemof_tabular_plugins/wefe/facades/mimo.py

MIMO.validate_datapackage = classmethod(validate_mimo_datapackage)
MIMO.processing_raw_inputs = classmethod(processing_mimo_raw_inputs)

which make sure the component is being created as datapackage with all its specificity (in that particular example the 'primary' field automatically gets updated to the foreign keys in the datapackage.json by the infer_metadata_from_data method, but it should not be interpreted as a foreign key. validate_datapackage removes it from the foreign keys in "datapackage.json file".

Ideas of solution

The candidate I see to adopt this are the reverse_osmosis and the apv MIMOs

Workflow checklist

@Bachibouzouk Bachibouzouk added the enhancement New feature or request label Jul 10, 2024
@Bachibouzouk
Copy link
Contributor Author

@MaaJoo13 @JulianBarinton FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant