Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor screen scroll even more #50

Open
rlamorea opened this issue May 16, 2024 · 0 comments
Open

Refactor screen scroll even more #50

rlamorea opened this issue May 16, 2024 · 0 comments
Assignees
Labels
cleanup Something is working but needs to be better

Comments

@rlamorea
Copy link
Owner

Issue #45 cut screen scrolling speed to a third of the original algorithm, and is probably ok for now.

But there is a faster way.

Effectively delete or insert cells and let the rest of them remain untouched.
So if we scroll up one line:

  • Delete the first cells from the cell array
  • Insert cells at the end of the cell array

Scrolling left one column would, for each line:

  • Insert one cell at 0 and every thereafter to end of screen
  • Delete one cell at 1+ (adjusted for the insert) and every thereafter to end of screen

This would mean:

  • removing the cell data-row/data-column attributes
  • selecting cells by nth child (or keep cells in array and use array index)
  • identifying selected cell by Array.from(parent.children).indexOf(child) approach
@rlamorea rlamorea added the cleanup Something is working but needs to be better label May 16, 2024
@rlamorea rlamorea self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Something is working but needs to be better
Projects
None yet
Development

No branches or pull requests

1 participant