Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the order of the args in lstsq in the APS agent's regress meta function correct? #30

Open
raymondchua opened this issue Feb 10, 2023 · 0 comments

Comments

@raymondchua
Copy link

raymondchua commented Feb 10, 2023

I am curious why in the regress_meta function in the APS agent, the reward is the first argument and not rep? According to the torch documentation, the lstsq function tries to find X in the the equation ||AX -B||_F, with A being the first argument and B being the second argument of the function. Since the equation that we are trying to solve is finding w, such that ||rep * w - reward||, shouldn't A be rep instead?

task = torch.linalg.lstsq(reward, rep)[0][:rep.size(1), :][0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant