-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hooks as a dev dependency #80
Comments
Just to say I haven't forgotten about this, I just need some time to think about it. I use commit hooks locally too :) All I can say for now is that we should refer everywhere (even in CI, which I didn't do) to the Makefile to have a single source of truth for the checks and linting. |
Oh no hurry, just came to mind as something I use a lot and might be useful for the project, but I think using a Makefile is also a good approach |
Or other option would just be to add |
I have tried it in the |
I'm a big fan of pre-commit hooks, as they can help avoid stupid mistakes like forgetting to run
black
auto formatting orisort
for sorting imports and so on.As an example of some to start with would be those similar used by PyMC3.
Happy to make a PR for this if it sounds like a good idea.
The text was updated successfully, but these errors were encountered: