Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread '<unnamed>' panicked at 'called Result::unwrap() on an Err value: "Player team unknown, #2

Open
colonelpanic8 opened this issue Apr 21, 2023 · 0 comments

Comments

@colonelpanic8
Copy link
Contributor

thread '' panicked at 'called Result::unwrap() on an Err value: "Player team unknown, Epic("3a8ed04bd45f42f2959f07c064e40fb1")"', /home/imalison/.cargo/git/checkouts/boxcar-frames-a2f2d9d2945dda9a/6f4043e/src/processor.rs:267:14 here’s an example: https://ballchasing.com/replay/c589a5ae-13d2-484a-862d-ff414f48a7eb (seems like it mostly happens with replays that don’t start at the beginning of the game) that said, we should probably work on a better way of determining player team (another example 79408dbe-f50a-4cf9-9c4c-0979bb68afbd).. At minimum, we need to get rid of the unwrap here, and propagate the error through a Result instead: https://github.com/CUBTeamRocket/boxcar-frames/blob/b566ff44a5cd238e3bda54a4f60a088a92bb67b1/src/processor.rs#L263 (another uuid 79408dbe-f50a-4cf9-9c4c-0979bb68afbd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant