v0.15.0 - Don't override helper, if it is provided

rniemeyer · Jul 14, 2016 · e84cd73 · e84cd73
1 parent ed571c7
commit e84cd73
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 22 deletions.
diff --git a/build/knockout-sortable.js b/build/knockout-sortable.js
@@ -1,4 +1,4 @@
-// knockout-sortable 0.14.1 | (c) 2016 Ryan Niemeyer |  http://www.opensource.org/licenses/mit-license
+// knockout-sortable 0.15.0 | (c) 2016 Ryan Niemeyer |  http://www.opensource.org/licenses/mit-license
 ;(function(factory) {
     if (typeof define === "function" && define.amd) {
         // AMD anonymous module
@@ -155,15 +155,17 @@
             startActual = sortable.options.start;
             updateActual = sortable.options.update;
 
-            //ensure draggable table row cells maintain their width while dragging
-            sortable.options.helper = function(e, ui) {
-                if (ui.is("tr")) {
-                    ui.children().each(function() {
-                        $(this).width($(this).width());
-                    });
-                }
-                return ui;
-            };
+            //ensure draggable table row cells maintain their width while dragging (unless a helper is provided)
+            if ( !sortable.options.helper ) {
+                sortable.options.helper = function(e, ui) {
+                    if (ui.is("tr")) {
+                        ui.children().each(function() {
+                            $(this).width($(this).width());
+                        });
+                    }
+                    return ui;
+                };
+            }
 
             //initialize sortable binding after template binding has rendered in update function
             var createTimeout = setTimeout(function() {

diff --git a/build/knockout-sortable.min.js b/build/knockout-sortable.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "knockout-sortable",
-  "version": "0.14.1",
+  "version": "0.15.0",
   "author": "Ryan Niemeyer",
   "homepage": "https://github.com/rniemeyer/knockout-sortable",
   "description": "A Knockout.js binding to connect observableArrays with jQuery UI sortable functionality",

diff --git a/src/knockout-sortable.js b/src/knockout-sortable.js
@@ -154,15 +154,17 @@
             startActual = sortable.options.start;
             updateActual = sortable.options.update;
 
-            //ensure draggable table row cells maintain their width while dragging
-            sortable.options.helper = function(e, ui) {
-                if (ui.is("tr")) {
-                    ui.children().each(function() {
-                        $(this).width($(this).width());
-                    });
-                }
-                return ui;
-            };
+            //ensure draggable table row cells maintain their width while dragging (unless a helper is provided)
+            if ( !sortable.options.helper ) {
+                sortable.options.helper = function(e, ui) {
+                    if (ui.is("tr")) {
+                        ui.children().each(function() {
+                            $(this).width($(this).width());
+                        });
+                    }
+                    return ui;
+                };
+            }
 
             //initialize sortable binding after template binding has rendered in update function
             var createTimeout = setTimeout(function() {