New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check children is not null #57

Open

kengreeff wants to merge 1 commit into rnosov:master from kengreeff:check-children-existence

+1 −1

kengreeff commented Feb 21, 2019

Javascript believes that null is an object. If children is null, the evaluation of typeof this.props.children === 'object' returns true`.

When evaluating the next line, typeof child.type === 'string' the script crashes because it can't check type of null.


          Check children is not null

6f48895

InsOpDe commented Mar 26, 2021

@noelzubin is there anything holding that PR back? Because the current master breaks things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet