Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roam "Document“ style missing #19

Open
tombarys opened this issue Mar 1, 2021 · 7 comments
Open

Roam "Document“ style missing #19

tombarys opened this issue Mar 1, 2021 · 7 comments
Labels
bug Something isn't working rendering roam-parity

Comments

@tombarys
Copy link

tombarys commented Mar 1, 2021

Describe the bug
It is not possible to publish blocks in Document mode (without bullets).

To Reproduce
Steps to reproduce the behavior:

  1. Create a page in Roam with text content and set all (or some) blocks to Document mode
  2. Plant a garden
  3. See all text is bulleted

Expected behavior
Roam.Garden should strictly differentiate between block modes.

@tombarys tombarys added the bug Something isn't working label Mar 1, 2021
@Stvad
Copy link
Member

Stvad commented Mar 1, 2021

Yeah, this information is missing from JSON export :(. So as long as I depend on it as source of truth, this will be challenging.
One workaround is to remove bullets with CSS, though you won't be able to be very selective with that.

@tombarys
Copy link
Author

tombarys commented Mar 1, 2021

Idea: what about adding a special tag for flagging a particular page as a Document-based on the first level? I guess it could be a workaround that should work for most situations when you want to simply share basic texts, poems, etc. Children of the doc-tagged page would be simple paragraphs (non-bullets), but children of this children could behave like bullets again.

@Stvad
Copy link
Member

Stvad commented Mar 3, 2021

That can be an option. I'm thinking about implementing convention of inferring the class for the block based on the tags inside similar to how Roam does, and this can be one of the use-cases. Need to do some refactoring first though. Btw you may find #17 interesting as it implements what you described for the whole Garden

@tombarys
Copy link
Author

tombarys commented Mar 7, 2021

Great. Thanks!

@Stvad
Copy link
Member

Stvad commented Mar 7, 2021

#26 would be an enabler for something like that

@JayFarei
Copy link

JayFarei commented May 8, 2021

Idea: what about adding a special tag for flagging a particular page as a Document-based on the first level? I guess it could be a workaround that should work for most situations when you want to simply share basic texts, poems, etc. Children of the doc-tagged page would be simple paragraphs (non-bullets), but children of this children could behave like bullets again.

In roam I use a similar technique => tag= .flattener

.flattener div.rm-block-children { margin-left:0!important;}
.flattener div.rm-multibar {border-right: 0px}

so long as we have classes in roam.garden to match that should do it?
(although I struggle with empty blocks)

@Stvad
Copy link
Member

Stvad commented May 8, 2021

Sounds reasonable. Also with #28 - I actually can get the "document" information as I do export manually vs relying on the default JSON export process. It'd only work when you use the plugin though 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rendering roam-parity
Projects
None yet
Development

No branches or pull requests

3 participants