Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Mink's base_url as Panther's external_base_uri #3

Open
dkarlovi opened this issue Feb 25, 2020 · 1 comment
Open

Pass Mink's base_url as Panther's external_base_uri #3

dkarlovi opened this issue Feb 25, 2020 · 1 comment

Comments

@dkarlovi
Copy link

Mink has a setting called base_url set for all sessions. Since it's basically what Panther's external_base_uri is doing, it makes sense to auto-wire this option into Panther if set.
robertfausk added a commit that referenced this issue Mar 29, 2020
@robertfausk
Add tests and init configuration support Refs #3 Closes #1
338dab1 
* add docker-compose support
* req --dev phpunit/phpunit matthiasnoback/symfony-config-test
so that they support at least php 7.1
* add unit tests and one behat test with chrome
* add PHP 7.4 to travis and adopt script section
* init CHANGELOG.md
robertfausk added a commit that referenced this issue Mar 29, 2020
@robertfausk
Add missing --config to .travis.yml Refs #3 Refs #1
13cf163
robertfausk added a commit that referenced this issue Mar 29, 2020
@robertfausk
Fix test_build_driver_without_options Refs #3 Refs #1
44ba5f7
@robertfausk
Copy link
Owner

@dkarlovi @storm1er Can you provide a PR including test pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkarlovi @robertfausk