Climate re-implementation

[stickpin]

Hi @robinostlund,

I need your help with Climate implementation. I don't know if it was working before all the latest changes.
Might be that we broke something. :)

I was working last weekend on implementing it with the temp control:

But I am stuck with the target_temperature property and don't know how to proceed without rewriting quite a big part of the code.

homeassistant-volkswagencarnet/custom_components/volkswagencarnet/climate.py

Line 118 in 3c17f11

def target_temperature(self):

Let me explain the problem that I am facing.
I have implemented the temp control and it works as expected, once the new settings are sent to the backend by using async_set_temperature, it's properly reflected in the climatisation target temperature sensor after callback and data refresh.
The problem is that a new temperature is not reflected in the control itself.

Any idea how to solve it?

[robinostlund]

Hi @stickpin
Sorry i missed this 😄

Well it has been working in the past, but it sounds like it is an update trigger that is missing. As currently it is the sensor itself for target temperature that is being update, not the climate. See them as individual entities. I don't remember exactly how it is working but you need to somehow get the climate entity to identify by itself that the value has been updated so it updates the state of the climate entity.

I have noticed though that more and more car integrations is moving this control over to button entities. What do you think about that? One button for starting the climatisation and one for stopping. And i think this is because of the complexicy and many dependencies for the climate entity type.

[stickpin]

@robinostlund I was checking an old code and it seems like it never went live:

        # ElectricClimatisationClimate(),
        # CombustionClimatisationClimate(),

https://github.com/robinostlund/volkswagencarnet/blob/213b9ae102bec6d87a9bef2bb30d472c2ebe2ea9/volkswagencarnet/vw_dashboard.py#L780

I can enable the climate On/Off switch but not the temperature control unless I move to the number entity slider or find a way to use the climate entity properly. But I am afraid the last one will require a lot of code rewrite on the frontend part which I am trying to avoid. :)

It looks like the climate entity missing a callback, but I don't know how to implement it.

[virtualdj]

Hi, when you say:

The problem is that a new temperature is not reflected in the control itself.

you mean that when the backend changes the target temperature (for example when a user changes the temp within the Volkswagen app) to a new value it appears on the entity here:

but does not on the control here:

?

If so, I have seen other Home Assistant integrations that change the self._attr_target_temperature on the ClimateEntity during an update.

Maybe you didn't apply that already? I'm not so skilled in Home Assistant integrations, though, but this is just what I've noticed.
Documentation doesn't help so much.

[stickpin]

Thanks @virtualdj very nice example! 👍
Seems like I finally managed to break through. 😅
If I will not be stuck somewhere once again, the next beta will come with temp control and on/off for electric climatisation.

[virtualdj]

@stickpin You're welcome and thanks for you work. I hope you can implement #547 too, whenever possible, because setting the charging current (maximum/limited) is a feature that I use so much with my Golf eHybrid and solar panels.

[migo-it]

The following error occurs with the new HomeAssistant-Volkswagencarnet 4.5.2

Logger: homeassistant.loader
Source: loader.py:842
First occurred: 09:48:09 (1 occurrences)
Last logged: 09:48:09

Unexpected exception importing platform custom_components.volkswagencarnet.climate
Traceback (most recent call last):
File "/lsiopy/lib/python3.11/site-packages/homeassistant/loader.py", line 842, in get_platform
cache[full_name] = self._import_platform(platform_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/lsiopy/lib/python3.11/site-packages/homeassistant/loader.py", line 859, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "/config/custom_components/volkswagencarnet/climate.py", line 47, in
class VolkswagenClimate(VolkswagenEntity, ClimateEntity):
File "/config/custom_components/volkswagencarnet/climate.py", line 53, in VolkswagenClimate
ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.TURN_OFF | ClimateEntityFeature.TURN_ON
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/enum.py", line 784, in getattr
raise AttributeError(name) from None
AttributeError: TURN_OFF

[stickpin]

Which version of Home Assistant do you use?

[migo-it]

Core 2024.1.6 Frontend 20240104.0 Am 19. Februar 2024 10:16:05 MEZ schrieb stickpin ***@***.***>:

…

Which version of Home Assistant do you use? -- Reply to this email directly or view it on GitHub: #568 (reply in thread) You are receiving this because you commented. Message ID: ***@***.***>

[stickpin]

@migo-it update to 2024.2.0+

[virtualdj]

@stickpin I'm trying 4.5.3 on a VM (where I have an updated Home Assistant version) and I don't see the Climate control. I've opened a separate bug as #577 to not pollute the thread here.