From 625c795785c50e152582dbbd2b27757c5a6ca877 Mon Sep 17 00:00:00 2001
From: Sebastiaan van Stijn <github@gone.nl>
Date: Mon, 1 Jul 2024 00:43:45 +0200
Subject: [PATCH] errdefs: FromStatusCode(): use early returns

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
---
 errdefs/http_helpers.go | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/errdefs/http_helpers.go b/errdefs/http_helpers.go
index ebcd789302714..0a8fadd48f1ff 100644
--- a/errdefs/http_helpers.go
+++ b/errdefs/http_helpers.go
@@ -11,36 +11,37 @@ func FromStatusCode(err error, statusCode int) error {
 	}
 	switch statusCode {
 	case http.StatusNotFound:
-		err = NotFound(err)
+		return NotFound(err)
 	case http.StatusBadRequest:
-		err = InvalidParameter(err)
+		return InvalidParameter(err)
 	case http.StatusConflict:
-		err = Conflict(err)
+		return Conflict(err)
 	case http.StatusUnauthorized:
-		err = Unauthorized(err)
+		return Unauthorized(err)
 	case http.StatusServiceUnavailable:
-		err = Unavailable(err)
+		return Unavailable(err)
 	case http.StatusForbidden:
-		err = Forbidden(err)
+		return Forbidden(err)
 	case http.StatusNotModified:
-		err = NotModified(err)
+		return NotModified(err)
 	case http.StatusNotImplemented:
-		err = NotImplemented(err)
+		return NotImplemented(err)
 	case http.StatusInternalServerError:
-		if !IsSystem(err) && !IsUnknown(err) && !IsDataLoss(err) && !IsDeadline(err) && !IsCancelled(err) {
-			err = System(err)
+		if IsCancelled(err) || IsSystem(err) || IsUnknown(err) || IsDataLoss(err) || IsDeadline(err) {
+			return err
 		}
+		return System(err)
 	default:
 		switch {
 		case statusCode >= 200 && statusCode < 400:
 			// it's a client error
+			return err
 		case statusCode >= 400 && statusCode < 500:
-			err = InvalidParameter(err)
+			return InvalidParameter(err)
 		case statusCode >= 500 && statusCode < 600:
-			err = System(err)
+			return System(err)
 		default:
-			err = Unknown(err)
+			return Unknown(err)
 		}
 	}
-	return err
 }