Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve imported package validation #567

Closed
ZdenekM opened this issue May 13, 2021 · 2 comments
Closed

Improve imported package validation #567

ZdenekM opened this issue May 13, 2021 · 2 comments
Labels
arcor2_build enhancement New feature or request

Comments

@ZdenekM
Copy link
Member

ZdenekM commented May 13, 2021

When importing an execution package, the Build service currently, for each object type in scene.json, tries to:

  • Parse its code (to check if the syntax is valid Python).
  • Import the ObjectType's class definition (to check whether all imports work and all ancestors are available).

Additionally, it should:

  • Raise an error if ObjectType.abstract() is True (abstract type can't be used in a scene as it has undefined/abstract methods and/or is marked as abstract manually/intentionally).
  • ??
@ZdenekM ZdenekM added enhancement New feature or request arcor2_build labels May 13, 2021
@martincervinka
Copy link

Is this issue somehow related to #690? @ZdenekM, can you explain it, please?

@ZdenekM
Copy link
Member Author

ZdenekM commented Jan 5, 2022

@martincervinka It is a (partial) duplicate, I will close it. But that brought me to the question - should we retain the import functionality? Do you use it? Let me know and I will update the issue.

@ZdenekM ZdenekM closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcor2_build enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants