Fix bio updates

robot-rumble · Mar 11, 2024 · 40a5a97 · 40a5a97
1 parent 8ad337c
commit 40a5a97
Showing 1 changed file with 21 additions and 15 deletions.
diff --git a/app/controllers/RobotController.scala b/app/controllers/RobotController.scala
@@ -122,23 +122,29 @@ class RobotController @Inject()(
               )
             },
             data => {
-              robotsRepo.findBare(user.id, data.name)(LoggedIn(user)) flatMap {
-                case Some(_) =>
-                  Future successful BadRequest(
-                    views.html.robot.update(
-                      UpdateRobotForm.form
-                        .fill(data)
-                        .withGlobalError("Robot with this name already exists"),
-                      robot,
-                      assetsFinder
-                    )
+              val success = () =>
+                robotsRepo.update(robot.id, data.name, data.bio, data.openSource) map { _ =>
+                  Redirect(
+                    routes.RobotController.view(user.username, data.name)
                   )
-                case None =>
-                  robotsRepo.update(robot.id, data.name, data.bio, data.openSource) map { _ =>
-                    Redirect(
-                      routes.RobotController.view(user.username, data.name)
+                }
+              if (data.name != robot.name) {
+                robotsRepo.findBare(user.id, data.name)(LoggedIn(user)) flatMap {
+                  case Some(_) =>
+                    Future successful BadRequest(
+                      views.html.robot.update(
+                        UpdateRobotForm.form
+                          .fill(data)
+                          .withGlobalError("Robot with this name already exists"),
+                        robot,
+                        assetsFinder
+                      )
                     )
-                  }
+                  case None =>
+                    success()
+                }
+              } else {
+                success()
               }
             }
           )