Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external blob values in robotinterface #3066

Open
wants to merge 3 commits into
base: yarp-3.9
Choose a base branch
from
Open

Add support for external blob values in robotinterface #3066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65fc9f1
Add support for external blob values in `extern-name`
PeterBowman Jun 20, 2024
3e3dff0
Add tests for externally configured lists and blobs
PeterBowman Jun 20, 2024
8795d43
Avoid dangling memory by passing double pointers as blobs
PeterBowman Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/release/yarp_3_9/yarprobotinterface_extern_blob.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#### `libYARP_robotinterface`

* Add support for blob values in the extra configuration passed to `XMLReader::getRobotFrom{File|String}` and linked in the XML via `extern-name`.
6 changes: 5 additions & 1 deletion src/libYARP_robotinterface/src/yarp/robotinterface/impl/XMLReaderFileV3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,11 @@ yarp::robotinterface::Param yarp::robotinterface::impl::XMLReaderFileV3::Private
// FIXME Check DTD >= 3.1
if (config.find(extern_name).isList())
{
param.value() = "(" + config.find(extern_name).asList()->toString() + ")";
param.value() = "(" + config.find(extern_name).toString() + ")";
}
else if (config.find(extern_name).isBlob())
{
param.value() = "{" + config.find(extern_name).toString() + "}";
}
else
{
Expand Down
Loading
Loading