Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voices as enum is a problematic design flaw #11

Open
bbottema opened this issue May 17, 2023 · 0 comments
Open

Voices as enum is a problematic design flaw #11

bbottema opened this issue May 17, 2023 · 0 comments

Comments

@bbottema
Copy link

bbottema commented May 17, 2023

I'm glad that you made this library, however one design choice kind of defeats the whole library: the ability to choose from a current list of voices.

As you encapsulated the voices as an enum you condemned yourself to having to upkeep your library with every change AWS Polly gets in the voice offerings, forever.

Case in point, the enum is missing voices (and might even have invalid ones) and there's nothing we can do to fix it. I saw another bug report mentioning this as well.

Just how 'model' (like "gpt3. 5-turbo" ) is a string property for OpenAi's api's, you should make voice a string property for Polly's api, and acknowledge that the list of voices is not something you control or should lock-in in an enum. Not even reflection code can touch that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant