You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm glad that you made this library, however one design choice kind of defeats the whole library: the ability to choose from a current list of voices.
As you encapsulated the voices as an enum you condemned yourself to having to upkeep your library with every change AWS Polly gets in the voice offerings, forever.
Case in point, the enum is missing voices (and might even have invalid ones) and there's nothing we can do to fix it. I saw another bug report mentioning this as well.
Just how 'model' (like "gpt3. 5-turbo" ) is a string property for OpenAi's api's, you should make voice a string property for Polly's api, and acknowledge that the list of voices is not something you control or should lock-in in an enum. Not even reflection code can touch that.
The text was updated successfully, but these errors were encountered:
I'm glad that you made this library, however one design choice kind of defeats the whole library: the ability to choose from a current list of voices.
As you encapsulated the voices as an enum you condemned yourself to having to upkeep your library with every change AWS Polly gets in the voice offerings, forever.
Case in point, the enum is missing voices (and might even have invalid ones) and there's nothing we can do to fix it. I saw another bug report mentioning this as well.
Just how 'model' (like "gpt3. 5-turbo" ) is a string property for OpenAi's api's, you should make voice a string property for Polly's api, and acknowledge that the list of voices is not something you control or should lock-in in an enum. Not even reflection code can touch that.
The text was updated successfully, but these errors were encountered: