Issue with file Locking

[kevinstreit]

Hi,

we are using your git plugin in our redmine (0.9.6) and got some file locking error recently. It is no longer possible for our users (students) to login since the Gitosis plugin tries to get a lock (in lib/gitosis.rb:21) which obviously sometimes fails.

Not related to that specific problem when trying to find the error we came over the GitosisObserver (app/models/gitosis_observer.rb), more specifically line 14. Is it correct that you call the update_repositories method there instead of the destroy_repositories method? We observed that the plugin does not delete the repositories (*.git) in the filesystem and as a workaround wrote a script that does it. But if this might be the cause why it doesn't delete them it might be a much better fix.

I'd appreciate any comment.

[lostar]

We have got the same issue. I do not have ruby dev experience (so my following assumptions can be wrong) but my investigations lead me to the following conclusion:
Login time depends on number of project in redmine because it will iterate over them (see vendor/plugins/redmine-gitosis/lib/gitosis.rb, method update_repositories) and rebuild gitosis configuration. So right now I've about 30 seconds lag at login time :(
Anybody know in which situations (except login procedure) will be called after_save method of GitosisObserver? I wanna comment line in update_repositories (gitosis_observer.rb) that handle user update notification but not sure that it is safe enough :)