Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced NFS entry does not allow comments. #2955

Open
phillxnet opened this issue Feb 18, 2025 · 0 comments
Open

Advanced NFS entry does not allow comments. #2955

phillxnet opened this issue Feb 18, 2025 · 0 comments
Labels
UI-enhancement Enhancement, renovation, update within Web-UI.

Comments

@phillxnet
Copy link
Member

When attempting to enter an Advanced NFS Export via: Storage -> NFS -> Advanced Edit (button):

Enter manual export entries below.

and enter a configuration starting with a comment # comment, we are greeted with the following:

Share with name (#) does not exist.

            Traceback (most recent call last):
  File "/opt/rockstor/src/rockstor/storageadmin/views/share_helpers.py", line 58, in validate_share
    return Share.objects.get(name=sname)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/rockstor/.venv/lib/python3.11/site-packages/django/db/models/manager.py", line 87, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/rockstor/.venv/lib/python3.11/site-packages/django/db/models/query.py", line 637, in get
    raise self.model.DoesNotExist(
storageadmin.models.share.Share.DoesNotExist: Share matching query does not exist.

It would be preferred, in an advanced entry, that we allow comments to be included.

@phillxnet phillxnet added the UI-enhancement Enhancement, renovation, update within Web-UI. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI-enhancement Enhancement, renovation, update within Web-UI.
Projects
None yet
Development

No branches or pull requests

1 participant