Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/update rules_python and pkg_tar #202

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

josephtate
Copy link

@josephtate josephtate commented Nov 12, 2024

This is required to build the project on a system with Python 3.12 or later.

C.f., bazelbuild/bazel#20211, especially the final comment.

@resf-prow
Copy link
Contributor

resf-prow bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josephtate
Once this PR has been reviewed and has the lgtm label, please assign mstg for approval by writing /assign @mstg in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@resf-prow
Copy link
Contributor

resf-prow bot commented Nov 12, 2024

Hi @josephtate. Thanks for your PR.

I'm waiting for a rocky-linux member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@josephtate josephtate changed the title Task/update rules python Task/update rules_python and pkg_tar Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant