Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!pinned flag should not be used in opam package for releases #208

Closed
palmskog opened this issue Jun 2, 2020 · 2 comments · Fixed by #407
Closed

!pinned flag should not be used in opam package for releases #208

palmskog opened this issue Jun 2, 2020 · 2 comments · Fixed by #407

Comments

@palmskog
Copy link
Collaborator

palmskog commented Jun 2, 2020

The !pinned flag is currently used in the version-tracked opam package definition (coq-serapi.opam).

However, this flag seemingly causes CI failures in the upstream opam repository, so it should never be part of opam package definitions for released versions of SerAPI (that are submitted to this opam repo). This should be accomplished with release automation, to avoid having to manual edit the opam file.

Some more background: ocaml/opam-repository#16564

@ejgallego
Copy link
Collaborator

ejgallego commented Jun 3, 2020

Thanks for the report @palmskog , note the comment of @kit-ty-kate here too:
ocaml/opam-repository#15850 (comment)

Apparently opam does not support !pinned (but does pinned):
[ERROR] undefined filter variable in dependencies of coq-serapi.8.11.0+0.11.0: pinned

It is a bit unclear to me how to best solve this, ideally we would not have to add some extra release step to the current standard dune-release workflow.

@ejgallego
Copy link
Collaborator

The error seems to have evolved in the latest release, we now just get Coq not installed in OPAM's CI due to the package being pinned? ocaml/opam-repository#17070 (comment)

ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
ejgallego added a commit that referenced this issue May 2, 2024
We also remove the old !pinned method, as the setup-ocaml action does
pin Coq in all cases.

Fixes #208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants