Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include SecurityCapabilities test in rbx_dom_lua #362

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

Dekkonot
Copy link
Member

With the introduction of SecurityCapabilities in #359, a value was added to the roundtrip test for rbx_dom_lua. This caused tests to begin to fail, as no pod was ever provided. However, in keeping with the theme of "we don't provide pods for values we don't use", we should simply not include a value for this type in tests to begin with.

This PR does exactly that, and allows rbx_dom_lua tests to pass once more.

@Dekkonot Dekkonot merged commit 8c4328e into rojo-rbx:master Sep 22, 2023
2 checks passed
@Dekkonot Dekkonot deleted the security-capabilities-no branch September 22, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants