Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement automation of build and release process #80

Open
3 tasks
jonasbn opened this issue Jan 25, 2022 · 3 comments · May be fixed by #108
Open
3 tasks

Implement automation of build and release process #80

jonasbn opened this issue Jan 25, 2022 · 3 comments · May be fixed by #108
Assignees
@jonasbn
Labels
todo A mere task to complete, which does not involve code changes

Comments

@jonasbn
Copy link
Collaborator

jonasbn commented Jan 25, 2022 •
edited
Loading

🔤 User Story

As a maintainer
I can build a Docker image automatically and have it uploaded to a container registry
so that I can make sure that it is built on a compatible platform

ℹ️ Notes

  • Issue Latest container version failing on runners due to architecture mismatch #79 demonstrated that it is better to have a automated build and release process to eliminate human error, in this case the human error was that the Docker image was build on a incompatible architecuture
  • Container registries could be one of:
    • DockerHub (currently uses)
    • GitHub Container Registry, ghcr for short
  • I is expected that at secret token is requested by the container registry chosen
    • This has tp be configured for the GitHub repository, this can be problematic since the repository is owned by somebody else than the current maintainer
  • Automated build is already in place, see: docker-build.yml

🆗 Acceptance Criteria

  • I can build automatically
  • I can push to a container registry
  • the built image is compatible with GitHub Actions

➡️ Resources and References

  • N/A
@jonasbn jonasbn self-assigned this Jan 25, 2022
@jonasbn jonasbn added the todo A mere task to complete, which does not involve code changes label Jan 25, 2022
@jonasbn jonasbn mentioned this issue Jan 25, 2022
Closed
@jonasbn jonasbn pinned this issue Feb 23, 2022
sxd added a commit to sxd/spellcheck-github-actions that referenced this issue Jul 14, 2022
@sxd
feat: add automated container build
a77e6b7 
Use the `docker/build-push` and `docker/metadata` actions to build
a container and add the proper tag depending on the branch, PR or
the tagged version using semver as the proper version.

Closes rojopolis#80

Signed-off-by: Jonathan Gonzalez V <[email protected]>
@sxd sxd linked a pull request Jul 14, 2022 that will close this issue
Open
@sxd
Copy link

sxd commented Jul 14, 2022

@jonasbn I just added a PR #108 that may help to fix this issue, don't know if it what you have on your mind, hope it will help.

On the other hand, will also add support for arm64 since I wanted to run the image on my raspberrypi but I wasn't able to do it

@jonasbn
Copy link
Collaborator Author

jonasbn commented Jul 15, 2022

Hi @sxd

Thank you, I will have a look at it over the weekend.

@sxd
Copy link

sxd commented Jul 15, 2022

Hi @jonasbn

Awesome!! I'll be waiting your feedback and requests!

Regards!

sxd added a commit to sxd/spellcheck-github-actions that referenced this issue Aug 5, 2022
@sxd
feat: add automated container build
3bd98bf 
Use the `docker/build-push` and `docker/metadata` actions to build
a container and add the proper tag depending on the branch, PR or
the tagged version using semver as the proper version.

Closes rojopolis#80

Signed-off-by: Jonathan Gonzalez V <[email protected]>
sxd added a commit to sxd/spellcheck-github-actions that referenced this issue Aug 5, 2022
@sxd
feat: add automated container build
6ca81e2 
Use the `docker/build-push` and `docker/metadata` actions to build
a container and add the proper tag depending on the branch, PR or
the tagged version using semver as the proper version.

Closes rojopolis#80

Signed-off-by: Jonathan Gonzalez V <[email protected]>
sxd added a commit to sxd/spellcheck-github-actions that referenced this issue Sep 2, 2024
@sxd
feat: add automated container build
4e51a53 
Use the `docker/build-push` and `docker/metadata` actions to build
a container and add the proper tag depending on the branch, PR or
the tagged version using semver as the proper version.

Closes rojopolis#80

Signed-off-by: Jonathan Gonzalez V <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasbn jonasbn

Labels
todo A mere task to complete, which does not involve code changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add automated container build sxd/spellcheck-github-actions
2 participants
@jonasbn @sxd